Hacker Newsnew | past | comments | ask | show | jobs | submit | aleaph's commentslogin

So "SHA pinning with version reference in a comment" with extra steps, got it

Yes, I scratched my head trying to understand what this accomplishes. It just puts a tag back instead of a SHA but now moves the SHA (locked in) to a separate file that now needs to be verified ? I fail to see how this is better or needed.

You can still use the SHA if you want to. What it achieves is transitive pinning (which this post doesn't properly highlight).

Lack of transitive pinning support was the biggest supply-chain security criticism against GHA and I'm glad they are finally tackling it!


SHA pinning on GitHub does not always imply account pinning, even where the account name is explicitly specified along with it.

So some of the extra steps are meaningful. Though I am still not convinced they could not have been implemented in a deliberately backwards-incompatible way to Github action in general, keeping the syntax and removing only the special case that is never both intentional and non-malicious at the same time.


Enforced through GitHub Actions that is :)

Yep, I don't think too many people are exposing their python/node servers directly, it should be always behind a proxy or a fancy cloud LB.

Apache and nginx don't handle brotli out of the box.


Your two sentences basically contradict one another, no? Apache doesn't handle brotli, so it will pass the compressed body to the underlying server undecoded, which means the underlying server is effectively exposed to attacks on this bug, if it does brotli decode on the body.


RAM is expensive. You can go a long way by using NGINX fastcgi cache for non-authenticated traffic, avoiding even hitting PHP altogether.


Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: