I have no idea why you're being downvoted -- the person who wrote the code shouldn't be deciding how readable it is, as they're clearly biased.
I had to deal with this the other day. I approved a PR, with a comment that 5-7 lines of the logic were unreadable and convoluted. I left a more concise way to write the code as a suggestion.
When I saw the merged code in master a few days later, I noticed that the convoluted logic was still there. When I asked them about it, they just said "well, to me, it's readable, so I decided to keep it".
¯\_(ツ)_/¯
Lesson for me: Don't approve PRs if I don't feel good about the quality of the code being committed.
Lesson for my coworker: If someone strongly disagrees with you, get a second opinion, don't just merge your code into master.
I had to deal with this the other day. I approved a PR, with a comment that 5-7 lines of the logic were unreadable and convoluted. I left a more concise way to write the code as a suggestion.
When I saw the merged code in master a few days later, I noticed that the convoluted logic was still there. When I asked them about it, they just said "well, to me, it's readable, so I decided to keep it".
¯\_(ツ)_/¯
Lesson for me: Don't approve PRs if I don't feel good about the quality of the code being committed.
Lesson for my coworker: If someone strongly disagrees with you, get a second opinion, don't just merge your code into master.