Eh, I have to use a MacBook Pro for work because of IT rules and I'm still not sold. Might be because I'm a Linux person who absolutely must have a fully customizable environment, but MacOS always feels so limited.
The devices are great and feel great. Definitely high quality (arguably, luxury!). The OS leaves a lot to be desired for me.
I spent about a decade before switching using Linux as my main :-) Mostly Gentoo and Ubuntu (man, it was good in the first few releases)
Got a job in dual-platform mobile dev and was issued a MacBook. Exposure to dozens of phones and tablets from both ecosystem. I was converted within a year.
(I barely customize anything these days, fwiw—hit the toggle for “caps as an extra ctrl”, brew install spectacle, done. Used to have opinions about my graphical login manager, use custom icon sets, all that stuff)
The devices are great and feel great. Definitely high quality (arguably, luxury!). The OS leaves a lot to be desired for me.