Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

So, it was hard to review 1000 lines in one PR.

And we solve this by splitting into 2 PRs that still merge at the same time. Oh, super useful!

Only if your reviews are so shallow that you don’t try to reason about the state of PR B merged to PR A, which would then be merged to main, and your real problem is just GitHub UI failing to handle a giant PR, which we all know that this feature is attempting to help with.



Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: